[
https://issues.apache.org/jira/browse/FLINK-22198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403517#comment-17403517
]
Jark Wu commented on FLINK-22198:
---------------------------------
[~xtsong] [~renqs][~lindong], personally, I'm -1 to change the test data because
1) it's hard to maintain, it's very trick to know which timestamp data should
use a future time. See the pull request changes 136 lines, but there still some
other timestamp not changed, not sure whether it changes all the necessary
places.
2) it may still broken in the future, e.g. some one add a test but not use a
long future timestamp (the test won't broken in a long time, and we need
another round to investigate the problem when it fails).
3) I don't see big difference between changing the timestamp data and disabling
log retention time. Is it common to insert 100 years later timestamp in
production environment?
4) It seems we also changed some default configs for kafka tests, e.g.
{{enable.auto.commit}}, {{auto.offset.reset}} in {{KafkaSinkITCase}} and
{{KafkaWriterITCase}}.
> KafkaTableITCase hang.
> ----------------------
>
> Key: FLINK-22198
> URL: https://issues.apache.org/jira/browse/FLINK-22198
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Kafka
> Affects Versions: 1.14.0, 1.12.4
> Reporter: Guowei Ma
> Assignee: Qingsheng Ren
> Priority: Blocker
> Labels: pull-request-available, stale-blocker, test-stability
> Fix For: 1.14.0
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=16287&view=logs&j=c5f0071e-1851-543e-9a45-9ac140befc32&t=1fb1a56f-e8b5-5a82-00a0-a2db7757b4f5&l=6625
> There is no any artifacts.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
