syhily commented on pull request #16900: URL: https://github.com/apache/flink/pull/16900#issuecomment-902874170
> Before doing a full-fledged review, I'd like to understand the scope a bit better since the PR is rather big as well. > Do you want to contribute the test utilities to improve > > * Test performance (avoiding unnecessary container spawns) > * Improve test stability (why would it improve stability?) > * Add more control over the system under test? (for example, to test more edge cases/failures) > > Are parts of these sources already present in the Pulsar repo? (= have they already matured?) I would like to answer these questions. Use an embedded pulsar is almost the same as using a container pulsar for tests. Therefore it can significantly improve the performance of the tests, avoid unnecessary container spawns. Some pulsar tests failure in Flink Azure CI is caused by container hanging. I think this embedded server may improve the test stability. Using a mocked pulsar broker can be operated by test. We truly add more control ability. These codes don't existed in Pulsar repo, the mock test on Pulsar side have to use powermock and manually config the pulsar broker. I have used the common pulsar `testmocks` module for mocking bookie and zookeeper. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
