fapaul commented on a change in pull request #16875:
URL: https://github.com/apache/flink/pull/16875#discussion_r692797381



##########
File path: 
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java
##########
@@ -139,6 +147,7 @@ public void write(IN element, Context context) throws 
IOException {
                 recordSerializer.serialize(element, kafkaSinkContext, 
context.timestamp());
         pendingRecords.incrementAndGet();
         currentProducer.send(record, deliveryCallback);
+        MetricUtil.sync(byteOutMetric, numBytesOutCounter);

Review comment:
       I registered a timer to update the metrics every 500ms, let me know if 
this is a reasonable time.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to