[ https://issues.apache.org/jira/browse/FLINK-23861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401496#comment-17401496 ]
Jark Wu commented on FLINK-23861: --------------------------------- Thanks [~zhangbinzaifendou], I just think performance shouldn't be the reason to introduce a new API, if the performance is a problem, then we should fix the performance problem. Otherwise, users still can't happily to use SET command. Personally, I'm not againt with {{-c k=v}} options. If it provides some kind of convenience, it's fine to introduce it, but I only have a minor suggestion that would be better to use {{-D}} instead of {{-c}} or {{--conf}} as the argument prefix, because this keeps align with Flink CLI behavior: https://ci.apache.org/projects/flink/flink-docs-master/docs/deployment/cli/ > flink sql client support dynamic params > --------------------------------------- > > Key: FLINK-23861 > URL: https://issues.apache.org/jira/browse/FLINK-23861 > Project: Flink > Issue Type: Improvement > Components: Table SQL / Client > Affects Versions: 1.13.2 > Reporter: zhangbinzaifendou > Priority: Minor > Labels: pull-request-available > Attachments: image-2021-08-18-23-41-13-629.png, > image-2021-08-18-23-42-04-257.png, image-2021-08-18-23-43-04-323.png > > > 1 Every time the set command is executed, the method call process is very > long and a new createTableEnvironment object is created > 2 As a result of the previous discussion in FLINK-22770, I don't think it's a > good habit for users to put quotes around keys and values. -- This message was sent by Atlassian Jira (v8.3.4#803005)