derekm opened a new pull request #16795:
URL: https://github.com/apache/flink/pull/16795


   ## What is the purpose of the change
   
   Allow sql-client.sh to work on Windows machines with "msys" bash.
   
   https://issues.apache.org/jira/browse/FLINK-23729
   
   ## Brief change log
   
     - Make manglePath() and manglePathList() in config.sh aware of "msys" 
$OSTYPE
     - Make log4j.configurationFile system property an absolute `file:` scheme 
path instead of a relative path
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   Changes to config.sh and sql-client.sh were manually tested on both Windows 
and Linux to find the appropriate minimal changes that would lead to identical 
behavior on both platforms.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to