tillrohrmann commented on a change in pull request #16766:
URL: https://github.com/apache/flink/pull/16766#discussion_r686106358
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/JobMasterTester.java
##########
@@ -239,21 +235,23 @@ private TaskExecutorGateway createTaskExecutorGateway() {
private CompletableFuture<Acknowledge> onSubmitTaskConsumer(
TaskDeploymentDescriptor taskDeploymentDescriptor, JobMasterId
jobMasterId) {
- return executionGraphInfoFuture.thenCompose(
Review comment:
Can't we remove `executionGraphInfoFuture`?
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherFailoverITCase.java
##########
@@ -64,15 +66,19 @@
/** An integration test for various fail-over scenarios of the {@link
Dispatcher} component. */
public class DispatcherFailoverITCase extends AbstractDispatcherTest {
- private static final Time TIMEOUT = Time.seconds(1);
-
private final BlockingQueue<RpcEndpoint> toTerminate = new
LinkedBlockingQueue<>();
@Before
public void setUp() throws Exception {
super.setUp();
final CompletedCheckpointStore completedCheckpointStore =
new EmbeddedCompletedCheckpointStore();
+ if (ClusterOptions.isAdaptiveSchedulerEnabled(configuration)) {
+ // Align timeouts for adaptive scheduler with test-wide timeouts.
+ configuration.set(JobManagerOptions.RESOURCE_WAIT_TIMEOUT,
Time.toDuration(TIMEOUT));
+ configuration.set(
+ JobManagerOptions.RESOURCE_STABILIZATION_TIMEOUT,
Time.toDuration(TIMEOUT));
+ }
Review comment:
I think these changes are not needed since we provide enough slots to
run the job with the desired parallelism.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
