Launche commented on a change in pull request #16757:
URL: https://github.com/apache/flink/pull/16757#discussion_r685656648
##########
File path: docs/data/sql_functions.yml
##########
@@ -240,7 +240,7 @@ arithmetic:
description: Returns a string representation of an integer NUMERIC value
or a STRING in hex format. Returns NULL if the argument is NULL. E.g. a numeric
20 leads to "14", a numeric 100 leads to "64", a string "hello,world" leads to
"68656C6C6F2C776F726C64".
- sql: TRUNCATE(numeric1, integer2)
table: numeric1.truncate(INTEGER2)
- description: Returns a numeric of truncated to integer2 decimal places.
Returns NULL if numeric1 or integer2 is NULL.If integer2 is 0,the result has no
decimal point or fractional part.integer2 can be negative to cause integer2
digits left of the decimal point of the value to become zero.This function can
also pass in only one numeric1 parameter and not set Integer2 to use.If
Integer2 is not set, the function truncates as if Integer2 were 0. E.g.
42.324.truncate(2) to 42.34. and 42.324.truncate() to 42.0.
+ description: Returns a numeric of truncated to integer2 decimal places.
Returns NULL if numeric1 or integer2 is NULL.If integer2 is 0,the result has no
decimal point or fractional part.integer2 can be negative to cause integer2
digits left of the decimal point of the value to become zero.This function can
also pass in only one numeric1 parameter and not set Integer2 to use.If
Integer2 is not set, the function truncates as if Integer2 were 0. E.g.
42.324.truncate(2) to 42.32. and 42.324.truncate() to 42.0.
Review comment:
Thanks for your advice. I ignored the fact that this approach is common
sense in the document specification, although I did not find the entry in the
Documentation Style Guide. I will fix these issues immediately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
