Myasuka commented on a change in pull request #16371:
URL: https://github.com/apache/flink/pull/16371#discussion_r684881212
##########
File path: docs/content/docs/ops/state/state_backends.md
##########
@@ -293,29 +293,38 @@ Below is an example how to define a custom
ConfigurableOptionsFactory (set class
```java
public class MyOptionsFactory implements ConfigurableRocksDBOptionsFactory {
-
private static final long DEFAULT_SIZE = 256 * 1024 * 1024; // 256 MB
- private long blockCacheSize = DEFAULT_SIZE;
+ public static final ConfigOption<MemorySize> BLOCK_CACHE_SIZE =
ConfigOptions
+ .key("my.custom.rocksdb.block.cache.size")
Review comment:
I think it's OK to modify like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
