pnowojski commented on a change in pull request #16726:
URL: https://github.com/apache/flink/pull/16726#discussion_r684452732
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -450,6 +454,16 @@ public int getNumberOfQueuedBuffers() {
}
}
+ @Override
+ public void bufferSize(int desirableNewBufferSize) {
+ if (desirableNewBufferSize < 0) {
+ return;
+ }
Review comment:
Why ignore negative numbers? Should we throw `IllegalArgumentException`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
