yittg commented on a change in pull request #16607:
URL: https://github.com/apache/flink/pull/16607#discussion_r679593191
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesConfigMapSharedInformer.java
##########
@@ -21,18 +21,17 @@
import org.apache.flink.kubernetes.kubeclient.KubernetesConfigMapSharedWatcher;
import io.fabric8.kubernetes.api.model.ConfigMap;
-import io.fabric8.kubernetes.api.model.ConfigMapList;
import io.fabric8.kubernetes.client.NamespacedKubernetesClient;
import java.util.Map;
/** The shared informer for {@link ConfigMap}, it can be used as a shared
watcher. */
public class KubernetesConfigMapSharedInformer
- extends KubernetesSharedInformer<ConfigMap, ConfigMapList,
KubernetesConfigMap>
+ extends KubernetesSharedInformer<ConfigMap, KubernetesConfigMap>
implements KubernetesConfigMapSharedWatcher {
public KubernetesConfigMapSharedInformer(
NamespacedKubernetesClient client, Map<String, String> labels) {
- super(client, ConfigMap.class, ConfigMapList.class, labels,
KubernetesConfigMap::new);
+ super(client, client.configMaps().withLabels(labels),
KubernetesConfigMap::new);
Review comment:
Should we add empty check here like before in the
`KubernetesSharedInformer`?
```
Preconditions.checkArgument(
!CollectionUtil.isNullOrEmpty(labels), "Labels must not be
null or empty");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
