zentol commented on a change in pull request #16607:
URL: https://github.com/apache/flink/pull/16607#discussion_r678959441
##########
File path: flink-kubernetes/src/main/resources/META-INF/NOTICE
##########
@@ -14,9 +14,27 @@ This project bundles the following dependencies under the
Apache Software Licens
- com.squareup.okhttp3:logging-interceptor:3.14.9
- com.squareup.okhttp3:okhttp:3.14.9
- com.squareup.okio:okio:1.17.2
-- io.fabric8:kubernetes-client:4.9.2
-- io.fabric8:kubernetes-model:4.9.2
Review comment:
I assume this module was just split?
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesSharedInformer.java
##########
@@ -102,18 +91,31 @@ public Watch watch(
@Override
public void run() {
- sharedInformerFactory.startAllRegisteredInformers();
+ startInformerAsync(sharedIndexInformer, aggregatedEventHandler);
}
@Override
public void close() {
- sharedInformerFactory.stopAllRegisteredInformers();
+ this.sharedIndexInformer.stop();
+ ExecutorUtils.gracefulShutdown(5, TimeUnit.SECONDS,
this.informerExecutor);
}
private String getResourceKey(String name) {
return client.getNamespace() + "/" + name;
}
+ private void startInformerAsync(
+ SharedIndexInformer<T> informer, SharedInformerEventListener
eventListener) {
+ informerExecutor.execute(
Review comment:
Why do need the executor for this? Is `run` such a heavy operation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
