[ 
https://issues.apache.org/jira/browse/FLINK-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15317012#comment-15317012
 ] 

ASF GitHub Bot commented on FLINK-4016:
---------------------------------------

Github user rvdwenden commented on the issue:

    https://github.com/apache/flink/pull/2070
  
    I checked in this change with this commit comment:
    [FLINK-3977] initialize FoldApplyWindowFunction properly 
    
    Hopefully that’s enough, however, on Travis CI I see that on my commit, the 
[FLINK-4016] is still triggered.
    
    Regards, RvdWenden    
    
    > On 06 Jun 2016, at 09:46, Aljoscha Krettek <notificati...@github.com> 
wrote:
    > 
    > Hi,
    > I wrote in the issue that you opened. This is a duplicate of 
https://issues.apache.org/jira/browse/FLINK-3977 
<https://issues.apache.org/jira/browse/FLINK-3977> and the way to fix it is to 
make InternalWindowFunction properly forward calls to setOutputType. If you 
want, could you please change your fix to that and open a PR against the older 
issue?
    > 
    > —
    > You are receiving this because you authored the thread.
    > Reply to this email directly, view it on GitHub 
<https://github.com/apache/flink/pull/2070#issuecomment-223889602>, or mute the 
thread 
<https://github.com/notifications/unsubscribe/ACoENn2sN0wGQAn7CaOt_c2R2i7utHKjks5qI9BKgaJpZM4ItrYw>.
    > 
    



> FoldApplyWindowFunction is not properly initialized
> ---------------------------------------------------
>
>                 Key: FLINK-4016
>                 URL: https://issues.apache.org/jira/browse/FLINK-4016
>             Project: Flink
>          Issue Type: Bug
>          Components: DataStream API
>    Affects Versions: 1.0.3
>            Reporter: RWenden
>            Priority: Blocker
>              Labels: easyfix
>             Fix For: 1.1.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> FoldApplyWindowFunction's outputtype is not set.
> We're using constructions like (excerpt):
>       .keyBy(0)
>       .countWindow(10, 5)
>       .fold(...)
> Running this stream gives an runtime exception in FoldApplyWindowFunction:
> "No initial value was serialized for the fold window function. Probably the 
> setOutputType method was not called."
> This can be easily fixed in WindowedStream.java by (around line# 449):
>             FoldApplyWindowFunction foldApplyWindowFunction = new 
> FoldApplyWindowFunction<>(initialValue, foldFunction, function);
>             foldApplyWindowFunction.setOutputType(resultType, 
> input.getExecutionConfig());
>             operator = new EvictingWindowOperator<>(windowAssigner,
>                     
> windowAssigner.getWindowSerializer(getExecutionEnvironment().getConfig()),
>                     keySel,
>                     
> input.getKeyType().createSerializer(getExecutionEnvironment().getConfig()),
>                     stateDesc,
>                     new 
> InternalIterableWindowFunction<>(foldApplyWindowFunction),
>                     trigger,
>                     evictor);



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to