[
https://issues.apache.org/jira/browse/FLINK-2832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316541#comment-15316541
]
ASF GitHub Bot commented on FLINK-2832:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/2076
[FLINK-2832] [tests] Hardens RandomSamplerTest
Increase the level of significance from p=0.01 to p=0.001 and add retry
annotations
to random sampler tests. This should decrease the probability of failing
random
sampler tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixRandomSamplerTest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2076.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2076
----
commit 3bf500eccd41e4094cd7951954bf44de845cb3ce
Author: Till Rohrmann <trohrm...@apache.org>
Date: 2016-06-06T14:19:30Z
[FLINK-2832] [tests] Hardens RandomSamplerTest
Increase the level of significance from p=0.01 to p=0.001 and add retry
annotations
to random sampler tests. This should decrease the probability of failing
random
sampler tests.
----
> Failing test: RandomSamplerTest.testReservoirSamplerWithReplacement
> -------------------------------------------------------------------
>
> Key: FLINK-2832
> URL: https://issues.apache.org/jira/browse/FLINK-2832
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.10.0
> Reporter: Vasia Kalavri
> Assignee: Till Rohrmann
> Priority: Critical
> Labels: test-stability
> Fix For: 1.0.0
>
>
> Tests run: 17, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 19.133 sec
> <<< FAILURE! - in org.apache.flink.api.java.sampling.RandomSamplerTest
> testReservoirSamplerWithReplacement(org.apache.flink.api.java.sampling.RandomSamplerTest)
> Time elapsed: 2.534 sec <<< FAILURE!
> java.lang.AssertionError: KS test result with p value(0.110000), d
> value(0.103090)
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at
> org.apache.flink.api.java.sampling.RandomSamplerTest.verifyKSTest(RandomSamplerTest.java:342)
> at
> org.apache.flink.api.java.sampling.RandomSamplerTest.verifyRandomSamplerWithSampleSize(RandomSamplerTest.java:330)
> at
> org.apache.flink.api.java.sampling.RandomSamplerTest.verifyReservoirSamplerWithReplacement(RandomSamplerTest.java:289)
> at
> org.apache.flink.api.java.sampling.RandomSamplerTest.testReservoirSamplerWithReplacement(RandomSamplerTest.java:192)
> Results :
> Failed tests:
>
> RandomSamplerTest.testReservoirSamplerWithReplacement:192->verifyReservoirSamplerWithReplacement:289->verifyRandomSamplerWithSampleSize:330->verifyKSTest:342
> KS test result with p value(0.110000), d value(0.103090)
> Full log [here|https://travis-ci.org/apache/flink/jobs/84120131].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
