fsk119 commented on pull request #16532: URL: https://github.com/apache/flink/pull/16532#issuecomment-883833173
Thanks for your contribution. Please make sure you pass the CI test at least before review. Currently I notice your branch fails because of the missing license. I find your branch still uses the YAML file to test SQL Client and Hive. However, this is not suggested right now. Could you do as the #15944 to use the SQL file as the init file? By the way I don't think it's the standard way to implement the E2E Tests? Please read the [doc](https://github.com/apache/flink/blob/master/flink-end-to-end-tests/README.md#writing-tests). I think we should start a real hive cluster. What do you think @lirui-apache? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
