leonardBang commented on a change in pull request #16337:
URL: https://github.com/apache/flink/pull/16337#discussion_r669321360
##########
File path: docs/content/docs/connectors/table/hbase.md
##########
@@ -176,14 +176,14 @@ Connector Options
<tr>
<td><h5>lookup.cache.max-rows</h5></td>
<td>optional</td>
- <td style="word-wrap: break-word;">(none)</td>
- <td>Integer</td>
+ <td style="word-wrap: break-word;">-1</td>
+ <td>Long</td>
<td>The max number of rows of lookup cache, over this value, the oldest
rows will be expired. Note, "lookup.cache.max-rows" and "lookup.cache.ttl"
options must all be specified if any of them is specified. Lookup cache is
disabled by default.</td>
</tr>
<tr>
<td><h5>lookup.cache.ttl</h5></td>
<td>optional</td>
- <td style="word-wrap: break-word;">(none)</td>
+ <td style="word-wrap: break-word;">0</td>
Review comment:
Should be `0 s` for `Duration` type
```suggestion
<td style="word-wrap: break-word;">0 s</td>
```
##########
File path: docs/content.zh/docs/connectors/table/hbase.md
##########
@@ -169,14 +169,14 @@ ON myTopic.key = hTable.rowkey;
<tr>
<td><h5>lookup.cache.max-rows</h5></td>
<td>可选</td>
- <td style="word-wrap: break-word;">(无)</td>
- <td>Integer</td>
+ <td style="word-wrap: break-word;">-1</td>
+ <td>Long</td>
<td>查找缓存的最大行数，超过这个值，最旧的行将过期。注意："lookup.cache.max-rows" 和
"lookup.cache.ttl" 必须同时被设置。默认情况下，查找缓存是禁用的。 </td>
</tr>
<tr>
<td><h5>lookup.cache.ttl</h5></td>
<td>可选</td>
- <td style="word-wrap: break-word;">(无)</td>
+ <td style="word-wrap: break-word;">0</td>
Review comment:
Should be `0 s` for `Duration` type
```suggestion
<td style="word-wrap: break-word;">0 s</td>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
