Thesharing commented on a change in pull request #16383:
URL: https://github.com/apache/flink/pull/16383#discussion_r666834205
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java
##########
@@ -470,36 +482,56 @@ private static void propagateIfNonNull(final Throwable
throwable) {
}
}
- private BiFunction<LogicalSlot, Throwable, Void>
assignResourceOrHandleError(
+ private BiFunction<LogicalSlot, Throwable, LogicalSlot> assignResource(
final DeploymentHandle deploymentHandle) {
final ExecutionVertexVersion requiredVertexVersion =
deploymentHandle.getRequiredVertexVersion();
final ExecutionVertexID executionVertexId =
deploymentHandle.getExecutionVertexId();
return (logicalSlot, throwable) -> {
if (executionVertexVersioner.isModified(requiredVertexVersion)) {
- log.debug(
- "Refusing to assign slot to execution vertex {}
because this deployment was "
- + "superseded by another deployment",
- executionVertexId);
- releaseSlotIfPresent(logicalSlot);
+ if (throwable == null) {
+ log.debug(
+ "Refusing to assign slot to execution vertex {}
because this deployment was "
+ + "superseded by another deployment",
+ executionVertexId);
+ releaseSlotIfPresent(logicalSlot);
+ }
Review comment:
I don't understand this very well. I'm wondering why the condition
`throwable == null`is added here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
