[ https://issues.apache.org/jira/browse/FLINK-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17374841#comment-17374841 ]
Timo Walther commented on FLINK-11398: -------------------------------------- [~jinyu.zj] I updated the component. This might be interesting for you? Otherwise we can also close it if you think it is not applicable to the new planner. > Add a dedicated phase to materialize time indicators for nodes produce updates > ------------------------------------------------------------------------------ > > Key: FLINK-11398 > URL: https://issues.apache.org/jira/browse/FLINK-11398 > Project: Flink > Issue Type: Improvement > Components: Table SQL / Planner > Reporter: Hequn Cheng > Priority: Minor > > As discussed > [here|https://github.com/apache/flink/pull/6787#discussion_r247926320], we > need a dedicated phase to materialize time indicators for nodes produce > updates. > Details: > Currently, we materialize time indicators in `RelTimeInidicatorConverter`. We > need to introduce another materialize phase that materializes all time > attributes on nodes that produce updates. We can not do it inside > `RelTimeInidicatorConverter`, because only later, after physical optimization > phase, we know whether it is a non-window outer join which will produce > updates > There are a few other things we need to consider. > - Whether we can unify the two converter phase. > - Take window with early fire into consideration(not been implemented yet). > In this case, we don't need to materialize time indicators even it produces > updates. -- This message was sent by Atlassian Jira (v8.3.4#803005)