Zakelly commented on a change in pull request #16341:
URL: https://github.com/apache/flink/pull/16341#discussion_r663863224
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -669,13 +677,18 @@ private void stopTaskExecutorServices() throws Exception {
taskInformation.getJobVertexId(),
tdd.getSubtaskIndex());
+ final StateChangelogStorage<?> changelogStorage =
+ changelogStoragesManager.stateChangelogStorageForJob(
+ jobId, jobInformation.getJobConfiguration());
Review comment:
I checked the code and IIUC, the configuration in
```taskInformation.getConfiguration()``` comes from the
```JobVertex.getConfiguration()``` and be set in ```TaskConfig```. It seems
that no checkpoint related configs should be set here.
As for the ```TaskExecutor.taskManagerConfiguration```, it is a
configuration for the cluster. Since there is a default value for changelog
storage, the job configuration will always override the one for cluster. I
don't think we need any configuration overriding here.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
