gaoyunhaii commented on a change in pull request #16351:
URL: https://github.com/apache/flink/pull/16351#discussion_r663856940
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java
##########
@@ -322,30 +322,11 @@ protected boolean isUsingCustomRawKeyedState() {
@Override
public void open() throws Exception {}
- /**
- * This method is called after all records have been added to the
operators via the methods
- * {@link OneInputStreamOperator#processElement(StreamRecord)}, or {@link
- * TwoInputStreamOperator#processElement1(StreamRecord)} and {@link
- * TwoInputStreamOperator#processElement2(StreamRecord)}.
- *
- * <p>The method is expected to flush all remaining buffered data.
Exceptions during this
- * flushing of buffered should be propagated, in order to cause the
operation to be recognized
- * asa failed, because the last data items are not processed properly.
- *
- * @throws Exception An exception in this method causes the operator to
fail.
- */
@Override
- public void close() throws Exception {}
+ public void finish() throws Exception {}
- /**
- * This method is called at the very end of the operator's life, both in
the case of a
- * successful completion of the operation, and in the case of a failure
and canceling.
- *
- * <p>This method is expected to make a thorough effort to release all
resources that the
- * operator has acquired.
- */
@Override
- public void dispose() throws Exception {
+ public void close() throws Exception {
Review comment:
Very thanks for the explanation! It indeed makes a lot of sense to me
and I also agree with the plan.
And for now perhaps we first complement `super.close()` for those three
operators? Since some of them indeed used states~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
