zentol commented on a change in pull request #16286: URL: https://github.com/apache/flink/pull/16286#discussion_r663778409
########## File path: flink-clients/src/main/java/org/apache/flink/client/deployment/application/FromJarEntryClassInformationProvider.java ########## @@ -68,11 +68,33 @@ private FromJarEntryClassInformationProvider( this.jobClassName = jobClassName; } + /** + * Returns the specified {@code jarFile}. If no {@code jarFile} was specified it can only return + * an empty {@code Optional} if the {@code jobClassName} is specified instead. In that case, the + * caller should assume that the passed job class can be found on the system classpath. + * + * @return The specified {@code jarFile}. If returning an empty {@code Optional} the caller + * should assume to find the job class on the system classpath. + * @see #getJobClassName() + */ @Override public Optional<File> getJarFile() { return Optional.ofNullable(jarFile); } + /** + * Returns the specified job class name that is either available in the corresponding {@code + * jarFile} or, if the {@code jarFile} is not set, should be assumed to be contained in the + * system classpath. It can return an emtpy {@code Optional} if the respective {@code jarFile} Review comment: emtpy -> empty -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org