rmetzger commented on a change in pull request #16283: URL: https://github.com/apache/flink/pull/16283#discussion_r660308177
########## File path: flink-table/flink-table-code-splitter/pom.xml ########## @@ -0,0 +1,91 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + + <modelVersion>4.0.0</modelVersion> + + <parent> + <artifactId>flink-table</artifactId> + <groupId>org.apache.flink</groupId> + <version>1.14-SNAPSHOT</version> + <relativePath>..</relativePath> + </parent> + + <artifactId>flink-table-code-splitter</artifactId> + <name>Flink : Table : Code Splitter </name> + <description> + This module contains a tool to split generated Java code + so that each method does not exceed the limit of 64KB. + Antlr grammar files are copied from the official antlr repository Review comment: Antlr has the BSD 3-clause license. https://github.com/antlr/antlr4/blob/master/LICENSE.txt That's a category A license: https://www.apache.org/legal/resolved.html#category-a, which allows us to include code into our project. I would recommend the following: **a) Mark the copied code** Add a comment like this if an entire file got copied: https://github.com/apache/flink/blob/99c2a415e9eeefafacf70762b6f54070f7911ceb/flink-filesystems/flink-fs-hadoop-shaded/src/main/java/org/apache/hadoop/util/NativeCodeLoader.java#L21-L28 If only parts of a file got copied, or if it is a file with mixed origin (parts are self-written/from Flink, the rest is copied), I would clearly indicate where the copied part starts and ends. It is important that people can see which code is from us, and which code is copied. **b) Add to NOTICE file of the module** Add an entry to the NOTICE file of the affected module, like this: https://github.com/apache/flink/blob/master/NOTICE#L17-L22 or **c) Ship the ANTLR license file in the module** File: https://github.com/antlr/antlr4/blob/master/LICENSE.txt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
