Thesharing opened a new pull request #16308: URL: https://github.com/apache/flink/pull/16308
## What is the purpose of the change *In FLINK-22988, TestUtils are ported from Scala to Java. However, SchedulerBenchmarkBase in flink-benchmark calls this method when each benchmark teardowns. This make SchedulerBenchmarks not compiling, as FLINK-23078 says. In #16250, we proposed to wrap `TestingUtils.defaultExecutor().shutdownNow()` into SchedulerBenchmarkUtil. In the discussion at https://github.com/apache/flink-benchmarks/pull/17, we decide to add a method `teardown()` for each scheduler benchmark, and close the executor in `teardown()` method.* ## Brief change log - *Make all scheduler benchmarks inherit a base class called `SchedulerBenchmarkBase`* - *Add `setup` method to `SchedulerBenchmarkBase` to setup the executor* - *Add `teardown` method to `SchedulerBenchmarkBase` to shutdown the executor* - *Add the call of `teardown` for the test cases* - *Rename `org.apache.flink.runtime.scheduler.benchmark.e2e.SchedulerBenchmarkBase` to `org.apache.flink.runtime.scheduler.benchmark.e2e.SchedulerEndToEnd`* for clarity ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
