[
https://issues.apache.org/jira/browse/FLINK-23009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369493#comment-17369493
]
Emre Kartoglu commented on FLINK-23009:
---------------------------------------
[~xintongsong] I'm having a look. Reverting the change to see if I receive the
error again. I'd like to point out that the error reported currently is
effectively the same as the error in FLINK-22492.
The difference is the error message in FLINK-22492 is
{code:java}
testTableApiSourceAndSink(org.apache.flink.streaming.kinesis.test.KinesisTableApiITCase)
Time elapsed: 59.283 s <<< FAILURE!
Apr 27 12:26:04 java.lang.AssertionError: expected:<3> but was:<0>
{code}
which is an assertion on the length, however that assertion has since been
removed as part of commit 442dc76bc76b9a7628202b33b21126ef3d48a90c.
Instead we currently have the assertion
{code:java}
List<Order> result = readAllOrdersFromKinesis(kinesisClient);
assertEquals(expected, result);
{code}
so the current error is indicating that the result list is empty (expected 3
objects).
I'm running the e2e test suite currently with the changes reverted. Please also
note that FLINK-22492 is still in progress, which makes me further confused if
I should or should not expect this failure. Will report back soon.
> Bump up Guava in Kinesis Connector
> ----------------------------------
>
> Key: FLINK-23009
> URL: https://issues.apache.org/jira/browse/FLINK-23009
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / Kinesis
> Reporter: Emre Kartoglu
> Assignee: Emre Kartoglu
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0, 1.12.5, 1.13.2
>
>
> *Background*
> We maintain a copy of the Flink connector in our AWS GitHub group:
> [https://github.com/awslabs/amazon-kinesis-connector-flink]
> We've recently upgraded the Guava library in our AWS copy as the version we
> were using was quite old and had incompatible interface differences with the
> later and more commonly used Guava versions. As part of this ticket we'll be
> applying the same changes in the Flink repo
> [https://github.com/apache/flink/tree/master/flink-connectors/flink-connector-kinesis]
>
> *Scope*
> * Upgrade Guava library in pom.xml
> * Switch to 3-arg version of Guava Futures.addCallback method call, as the
> old 2-arg version is no longer supported
> *Result*
> All existing and new tests should pass
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
