[
https://issues.apache.org/jira/browse/FLINK-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301910#comment-15301910
]
ASF GitHub Bot commented on FLINK-3972:
---------------------------------------
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2037
[FLINK-3972] subclasses of ResourceID may not to be serializable
WorkerTypes are currently subclasses of ResourceID. ResourceID implements
Serializable but not necessarily its subclasses. This may lead to problems when
these subclasses are used as ResourceIDs, i.e. serialization may fail with
NotSerializableExceptions. Currently, subclasses are never send over the wire
but they might be in the future.
Instead of relying on subclasses of ResourceID for the WorkerTypes, we can
let them implement an interface to retrieve the ResourceID of a WorkerType.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK-3972
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2037.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2037
----
commit c9dc0fe52625d4d455a9305976c644c10bf877ea
Author: Maximilian Michels <m...@apache.org>
Date: 2016-05-25T15:20:34Z
[FLINK-3972] subclasses of ResourceID may not to be serializable
WorkerTypes are currently subclasses of ResourceID. ResourceID
implements Serializable but not necessarily its subclasses. This may
lead to problems when these subclasses are used as ResourceIDs,
i.e. serialization may fail with NotSerializableExceptions. Currently,
subclasses are never send over the wire but they might be in the future.
Instead of relying on subclasses of ResourceID for the WorkerTypes, we
can let them implement an interface to retrieve the ResourceID of a
WorkerType.
----
> Subclasses of ResourceID may not to be serializable
> ---------------------------------------------------
>
> Key: FLINK-3972
> URL: https://issues.apache.org/jira/browse/FLINK-3972
> Project: Flink
> Issue Type: Bug
> Components: ResourceManager
> Affects Versions: 1.1.0
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Minor
> Fix For: 1.1.0
>
>
> WorkerTypes are currently subclasses of ResourceID. ResourceID has to be
> Serializable but its subclasses don't. This may lead to problems when these
> subclasses are used as ResourceIDs, i.e. serialization may fail with
> NotSerializableExceptions. Currently, subclasses are never send over the wire
> but they might be in the future.
> Instead of relying on subclasses of ResourceID for the WorkerTypes, we can
> let them implement an interface to retrieve the ResourceID of a WorkerType.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
