[ 
https://issues.apache.org/jira/browse/FLINK-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301895#comment-15301895
 ] 

ASF GitHub Bot commented on FLINK-3967:
---------------------------------------

Github user mans2singh commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2031#discussion_r64720893
  
    --- Diff: flink-streaming-connectors/flink-connector-rethinkdb/pom.xml ---
    @@ -0,0 +1,100 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0";
    +            xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +            xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd";>
    +
    +   <modelVersion>4.0.0</modelVersion>
    +
    +   <parent>
    +           <groupId>org.apache.flink</groupId>
    +           <artifactId>flink-streaming-connectors</artifactId>
    +           <version>1.1-SNAPSHOT</version>
    +           <relativePath>..</relativePath>
    +   </parent>
    +
    +   <artifactId>flink-connector-rethinkdb_2.10</artifactId>
    +   <name>flink-connector-rethinkdb</name>
    +
    +   <packaging>jar</packaging>
    +
    +   <!-- Allow users to pass custom connector versions -->
    +   <properties>
    +           <rethinkdb.version>2.3.0</rethinkdb.version>
    +   </properties>
    +
    +   <dependencies>
    +
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   <artifactId>flink-streaming-java_2.10</artifactId>
    +                   <version>${project.version}</version>
    +                   <scope>provided</scope>
    +           </dependency>
    +
    +        <dependency>
    +            <groupId>com.google.guava</groupId>
    +            <artifactId>guava</artifactId>
    +            <version>${guava.version}</version>
    +        </dependency>
    +
    +        <dependency>
    +            <groupId>org.apache.flink</groupId>
    +            <artifactId>flink-streaming-java_2.10</artifactId>
    +            <version>${project.version}</version>
    +            <scope>test</scope>
    +            <type>test-jar</type>
    +        </dependency>
    +
    +        <dependency>
    +            <groupId>org.apache.flink</groupId>
    +            <artifactId>flink-tests_2.10</artifactId>
    +            <version>${project.version}</version>
    +            <scope>test</scope>
    +        </dependency>
    +
    +        <dependency>
    +            <groupId>org.apache.flink</groupId>
    +            <artifactId>flink-test-utils_2.10</artifactId>
    +            <version>${project.version}</version>
    +                           <type>test-jar</type>
    +            <scope>test</scope>
    +        </dependency>
    +   <dependency>
    +       <groupId>com.rethinkdb</groupId>
    +       <artifactId>rethinkdb-driver</artifactId>
    +       <version>${rethinkdb.version}</version>
    +        </dependency>
    --- End diff --
    
    Hi @rmetzger 
    
    Thanks for pointing the license issue.  I wanted to get your advice on two 
other options:
    
    1. Can I contribute it as as other Flink contributions (under flink-contrib 
module) ?
    2. There is another java-driver available for RethinkDB 
(https://github.com/npiv/rethink-java-driver), available under Apache License 
2.0.  If that is acceptable for a contribution to Flink, I can see if I can 
migrate the sink to that driver.  
    
    If you have any other recommendations, please let me know.
    
    Thanks.


> Provide RethinkDB Sink for Flink
> --------------------------------
>
>                 Key: FLINK-3967
>                 URL: https://issues.apache.org/jira/browse/FLINK-3967
>             Project: Flink
>          Issue Type: New Feature
>          Components: Streaming, Streaming Connectors
>    Affects Versions: 1.0.3
>         Environment: All
>            Reporter: Mans Singh
>            Assignee: Mans Singh
>            Priority: Minor
>              Labels: features
>             Fix For: 1.1.0
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Provide Sink to stream data from flink to rethink db.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to