Airblader commented on a change in pull request #16283: URL: https://github.com/apache/flink/pull/16283#discussion_r658472428
########## File path: flink-table/flink-table-code-splitter/src/main/java/org/apache/flink/table/codesplit/CodeSplitUtil.java ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.codesplit; + +import org.antlr.v4.runtime.CharStream; +import org.antlr.v4.runtime.ParserRuleContext; +import org.antlr.v4.runtime.misc.Interval; + +import java.util.concurrent.atomic.AtomicLong; + +/** Utils for rewriters. */ +public class CodeSplitUtil { Review comment: All classes seem to be missing `@Internal` annotations. ########## File path: flink-table/flink-table-code-splitter/pom.xml ########## @@ -0,0 +1,91 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + + <modelVersion>4.0.0</modelVersion> + + <parent> + <artifactId>flink-table</artifactId> + <groupId>org.apache.flink</groupId> + <version>1.14-SNAPSHOT</version> + <relativePath>..</relativePath> + </parent> + + <artifactId>flink-table-code-splitter</artifactId> + <name>Flink : Table : Code Splitter </name> + <description> + This module contains a tool to split generated Java code + so that each method does not exceed the limit of 64KB. + Antlr grammar files are copied from the official antlr repository Review comment: Given that files are copied verbatim from other projects, how will this be handled in terms of licensing? ########## File path: flink-table/flink-table-code-splitter/src/main/antlr4/JavaLexer.g4 ########## @@ -0,0 +1,184 @@ +/** Review comment: The original BSD license has been removed. I think this violates the licensing terms. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
