Airblader opened a new pull request #16213:
URL: https://github.com/apache/flink/pull/16213


   ## What is the purpose of the change
   
   When working with hundreds of fields, equalisers can fail to compile
   because the method body grows beyond 64kb. With this change, instead of
   generating all code into one method, we generate a dedicated method per
   field and then call all of those methods. This doesn't entirely remove
   the problem, but supports roughly a factor of 10 more fields and is
   currently deemed sufficient.
   
   ## Brief change log
   
   - Adjust `EqualiserCodeGenerator` to generate one method per field and call 
those methods.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   - `EqualiserCodeGeneratorTest`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): yes
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to