[
https://issues.apache.org/jira/browse/FLINK-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15296362#comment-15296362
]
ASF GitHub Bot commented on FLINK-2314:
---------------------------------------
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/2020#issuecomment-220981894
All in all, very good work!
One thing I'd like to change is the order of parameters in the `readFile`
methods. For these telescoping methods is usual to append new parameters to the
end. For example in these two methods, where you add the additional filter
method the filter would go to the end on the second method because it is an
additional parameter. This way, users can just append additional parameters to
existing ones without changing the order.
```
public <OUT> DataStreamSource<OUT> readFile(FileInputFormat<OUT>
inputFormat,
String filePath,
WatchType watchType,
long interval)
```
```
public <OUT> DataStreamSource<OUT> readFile(FileInputFormat<OUT>
inputFormat,
String filePath,
WatchType watchType,
FilePathFilter filter,
long interval)
```
> Make Streaming File Sources Persistent
> --------------------------------------
>
> Key: FLINK-2314
> URL: https://issues.apache.org/jira/browse/FLINK-2314
> Project: Flink
> Issue Type: Improvement
> Components: Streaming
> Affects Versions: 0.9
> Reporter: Stephan Ewen
> Assignee: Kostas Kloudas
>
> Streaming File sources should participate in the checkpointing. They should
> track the bytes they read from the file and checkpoint it.
> One can look at the sequence generating source function for an example of a
> checkpointed source.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
