Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/2020#issuecomment-220981894
All in all, very good work!
One thing I'd like to change is the order of parameters in the `readFile`
methods. For these telescoping methods is usual to append new parameters to the
end. For example in these two methods, where you add the additional filter
method the filter would go to the end on the second method because it is an
additional parameter. This way, users can just append additional parameters to
existing ones without changing the order.
```
public <OUT> DataStreamSource<OUT> readFile(FileInputFormat<OUT>
inputFormat,
String filePath,
WatchType watchType,
long interval)
```
```
public <OUT> DataStreamSource<OUT> readFile(FileInputFormat<OUT>
inputFormat,
String filePath,
WatchType watchType,
FilePathFilter filter,
long interval)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
