wuchong commented on pull request #16060:
URL: https://github.com/apache/flink/pull/16060#issuecomment-856413047


   Thanks a lot for the contribution @RocMarshal . 
   
   I though this PR was aiming to add description for the missing `EXIST` 
command, but this seems adding all SQL syntax. I'm a bit worried, because the 
list is too verbose and hard to maintain as we are adding more and more syntax 
and some of them may be very complex (see MySQL CREATE TABLE syntax). MySQL and 
Hive doesn't dispaly all SQL syntax but just some CLI commnads when typing 
`HELP`. See:
   
   
![image](https://user-images.githubusercontent.com/5378924/121116388-07905780-c849-11eb-993e-06f76e8c3e24.png)
   
   I think we have two ways to improve this:
   1) not display full syntax, but the most common used syntax or example, e.g. 
`CREATE FUNCTION <function_name> AS '<class_name>'`.
   2) just displaying CLI related commands (e.g. EXIST, CLEAR, HELP, etc...)
   
   What's your opinions? @twalthr @leonardBang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to