SteNicholas commented on a change in pull request #16040:
URL: https://github.com/apache/flink/pull/16040#discussion_r647080119
##########
File path:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/maxwell/MaxwellJsonDeserializationSchema.java
##########
@@ -162,25 +209,70 @@ public boolean equals(Object o) {
return false;
}
MaxwellJsonDeserializationSchema that =
(MaxwellJsonDeserializationSchema) o;
- return ignoreParseErrors == that.ignoreParseErrors
- && fieldCount == that.fieldCount
- && Objects.equals(jsonDeserializer, that.jsonDeserializer)
- && Objects.equals(resultTypeInfo, that.resultTypeInfo);
+ return Objects.equals(jsonDeserializer, that.jsonDeserializer)
+ && hasMetadata == that.hasMetadata
Review comment:
@lirui-apache If two instances both require metadata but the required
fields are different, the `jsonDeserializer` is different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
