[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291081#comment-15291081
 ] 

ASF GitHub Bot commented on FLINK-3909:
---------------------------------------

Github user mxm commented on the pull request:

    https://github.com/apache/flink/pull/2003#issuecomment-220321817
  
    Thanks for looking into the problem and providing a detailed explanation 
@markreddy. I think we're good to go with the newest version of the Surefire 
plugin. I verified the tests 1) fail when errors occur 2) are actually run 
(added some debug output) 3) the number of tests/ITCases remains unchanged.
    
    Just running one more time because I forgot to set the default of 
`reuseForks` to false for the integration tests. Reusing of forks doesn't work 
for some tests because of garbage collection problems (this was the same for 
the Failsafe plugin). Apparently almost all tests pass. So looking forward to 
merging this soon.


> Maven Failsafe plugin may report SUCCESS on failed tests
> --------------------------------------------------------
>
>                 Key: FLINK-3909
>                 URL: https://issues.apache.org/jira/browse/FLINK-3909
>             Project: Flink
>          Issue Type: Bug
>          Components: Build System
>    Affects Versions: 1.1.0
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>             Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to