cmick commented on a change in pull request #16023:
URL: https://github.com/apache/flink/pull/16023#discussion_r646014934
##########
File path:
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSourceTest.java
##########
@@ -419,6 +421,40 @@ protected Connection setupConnection() throws Exception {
Mockito.verify(channel, Mockito.times(0)).basicQos(anyInt());
}
+ private static class CallsRealMethodsWithDelay extends CallsRealMethods {
+
+ private final long delay;
+
+ public CallsRealMethodsWithDelay(long delay) {
+ this.delay = delay;
+ }
+
+ public Object answer(InvocationOnMock invocation) throws Throwable {
+ Thread.sleep(delay);
+ return super.answer(invocation);
+ }
+ }
+
+ @Test(timeout = 10000L)
+ public void testDeliveryTimeout() throws Exception {
+ source.autoAck = false;
+ // mock delivery delay
+ Mockito.when(source.consumer.nextDelivery())
+ .then(new CallsRealMethodsWithDelay(15000L))
+ .thenThrow(new RuntimeException());
+ Mockito.when(source.consumer.nextDelivery(any(Long.class)))
+ .then(new CallsRealMethodsWithDelay(10L))
+ .thenReturn(null);
+ sourceThread.start();
+ // wait a bit for the source to start
+ Thread.sleep(5);
Review comment:
I refactored the delivery timeout unit test so that it does not rely on
any timeouts or processing time at all (changes in a229e25). I also moved the
helper class after all `@Test` methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
