sunxiaoguang commented on pull request #16057: URL: https://github.com/apache/flink/pull/16057#issuecomment-854321050
> cc @mbalassi @gyfora > > @sunxiaoguang we've seen you're struggling w/ tests for quite some time and we would like to help you out by contributing our implementation which works already in production. Hope this helps. > As I've seen you would like to add more weak authentications. My view on that it that it's not giving any business/return in investment advantage having more than one. > > @tillrohrmann this is the basic (weak) authentication part and kerberos SPNEGO (strong) authentication has similar complexity but it's depending on this change. When these 2 added no further implementation is planned. > Just to give some reasoning why I've made the split: having horror huge PRs would make the review extremely hard which just wastes everybody's time. > > Comments/suggestions are welcome as always. Well, I‘m ok as long as our concern about security is covered. The reason I didn't put tests is that I would like to hear some feedback about the PR from the community in case the implementation would be changed and the test has to be changed as well. So basically there is no struggling but I'd be glad to see that this is fix somehow in community. As long as the community reaches consensus and it definitely doesn't have to be my effort. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
