Airblader commented on a change in pull request #16020:
URL: https://github.com/apache/flink/pull/16020#discussion_r643086388
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/expressions/converter/DirectConvertRule.java
##########
@@ -160,6 +160,9 @@
DEFINITION_OPERATOR_MAP.put(BuiltInFunctionDefinitions.HEX,
FlinkSqlOperatorTable.HEX);
DEFINITION_OPERATOR_MAP.put(
BuiltInFunctionDefinitions.TRUNCATE,
FlinkSqlOperatorTable.TRUNCATE);
+ DEFINITION_OPERATOR_MAP.put(
Review comment:
Implementing the functions here and in `FlinkSqlOperatorTable`
duplicates their type strategy information from the new function stack. We can
avoid that by not adding this in those two places, however it requires
9fa35290497c5e875eb9404e245f0847c3dac4b8 from
https://github.com/apache/flink/pull/16046 (something I discussed with
@twalthr). It would be nice, though, to not duplicate the type signatures for
these functions and implementing them in both the old and new stack.
Ideally we'd even implement GREATEST and LEAST entirely on the new stack,
but I think this isn't yet possible, so going through code generation should be
fine for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
