AHeise commented on a change in pull request #16019:
URL: https://github.com/apache/flink/pull/16019#discussion_r642952611
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/TaskStateAssignment.java
##########
@@ -169,31 +170,37 @@ public OperatorSubtaskState
getSubtaskState(OperatorInstanceID instanceID) {
instanceID,
inputOperatorID,
getUpstreamAssignments(),
- assignment ->
- assignment.outputSubtaskMappings.get(
- getAssignmentIndex(
-
assignment.getDownstreamAssignments(),
- this)),
- assignment ->
- assignment.getOutputMapping(
- getAssignmentIndex(
-
assignment.getDownstreamAssignments(),
- this)),
+ (assignment, recompute) -> {
Review comment:
Well the flag expresses more the intent and you avoid passing to
seemingly identical lambdas to the same function. I don't know what the issue
with the `public method is` but you could add a non-public overload.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
