beyond1920 commented on a change in pull request #14830:
URL: https://github.com/apache/flink/pull/14830#discussion_r633364916



##########
File path: 
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/GroupWindowITCase.scala
##########
@@ -18,6 +18,8 @@
 
 package org.apache.flink.table.planner.runtime.stream.sql
 
+import java.math.BigDecimal

Review comment:
       @godfreyhe Thanks for the review, I have addressed all your comments, 
including add UT and IT about window aggregate consumes upsert input stream. 
please have a look, Thanks.
   BTW, an unexpected exception is thrown out when add IT for window aggregate 
consumes upsert input stream. I create an issue 
[FLINK-22680](https://issues.apache.org/jira/browse/FLINK-22680) for the bug. 
And I only add a simple ITCase in `GroupWindowITCase.scala` which could avoid 
the bug in this pr.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to