[ 
https://issues.apache.org/jira/browse/FLINK-22529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345964#comment-17345964
 ] 

Konstantin Knauf commented on FLINK-22529:
------------------------------------------

+1

> StateFun Kinesis ingresses should support configs that are available via 
> FlinkKinesisConsumer's ConsumerConfigConstants
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-22529
>                 URL: https://issues.apache.org/jira/browse/FLINK-22529
>             Project: Flink
>          Issue Type: Improvement
>          Components: Stateful Functions
>            Reporter: Tzu-Li (Gordon) Tai
>            Priority: Major
>             Fix For: statefun-3.1.0
>
>
> The Kinesis ingress should support the configs that are available in 
> {{FlinkKinesisConsumer}}'s {{ConsumerConfigConstants}}. Instead, currently, 
> all property keys provided to the Kinesis ingress are assumed to be 
> AWS-client related keys, and therefore have all been appended with the 
> `aws.clientconfigs` string.
> I'd suggest to avoid mixing the {{ConsumerConfigConstants}} configs within 
> the properties as well. Having named methods on the {{KinesisIngressBuilder}} 
> for those configuration would provide a cleaner solution.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to