[ 
https://issues.apache.org/jira/browse/FLINK-22475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timo Walther closed FLINK-22475.
--------------------------------
    Fix Version/s: 1.13.1
                   1.14.0
       Resolution: Fixed

Fixed in 1.14.0:

abd3da9e0a28aaa526a569133feadfe0c9af68cc
[table-api-java-bridge] Add placeholder options for datagen connector

6be47cc5baa098e12855f7727c6c4336298bef91
[table-common] Exclude options with '#' placeholder from validation of required 
options

61e8a926e825a407cc5f1f3a9b7502a325f3ea0a
[table-common] Document usage of '#' placeholder in option keys

Fixed in 1.13.1 to automate option generation:

4f6e0dd5741cb13e38b9ede7183805290e0d22ce
[table-api-java-bridge] Add placeholder options for datagen connector

dd1c1bc19169a53755be96c5cf1e5e80c76a9145
[table-common] Exclude options with '#' placeholder from validation of required 
options

6bf648aecf31d4253ecaf64bc6df16401397cbeb
[table-common] Document usage of '#' placeholder in option keys

> Datagen connector does not list its available options with placeholders
> -----------------------------------------------------------------------
>
>                 Key: FLINK-22475
>                 URL: https://issues.apache.org/jira/browse/FLINK-22475
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / Ecosystem
>    Affects Versions: 1.12.2, 1.13.0
>            Reporter: Ingo Bürk
>            Assignee: Ingo Bürk
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.14.0, 1.13.1
>
>
> The Datagen connector provides optional options like "field.#.max" which 
> contain placeholders as the option is to be set per-field. However, its 
> factory does not list these placeholder options at all.
> In order to generate connector documentation from code, the factory should 
> list these placeholder options.
> Additionally, we should "standardize" the usage of '#' as a placeholder, 
> document it on the Factory interface and possibly even extend the validation 
> helper to 1) ignore required properties containing a '#' and 2) reject 
> provided options containing a '#' in their key.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to