Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1981#discussion_r63255146
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
 ---
    @@ -334,6 +335,156 @@ class Table(
         * }}}
         */
       def join(right: Table): Table = {
    +    join(right, new Literal(true, TypeInformation.of(classOf[Boolean])), 
JoinType.INNER)
    +  }
    +
    +  /**
    +    * Joins two [[Table]]s. Similar to an SQL join. The fields of the two 
joined
    +    * operations must not overlap, use [[as]] to rename fields if 
necessary.
    +    *
    +    * Note: Both tables must be bound to the same [[TableEnvironment]].
    +    *
    +    * Example:
    +    *
    +    * {{{
    +    *   left.join(right, "a = b && c > 3")
    +    * }}}
    +    */
    +  def join(right: Table, joinPredicate: String): Table = {
    +    join(right, joinPredicate, JoinType.INNER)
    +  }
    +
    +  /**
    +    * Joins two [[Table]]s. Similar to an SQL join. The fields of the two 
joined
    +    * operations must not overlap, use [[as]] to rename fields if 
necessary.
    +    *
    +    * Note: Both tables must be bound to the same [[TableEnvironment]].
    +    *
    +    * Example:
    +    *
    +    * {{{
    +    *   left.join(right, 'a === 'b && 'c > 3).select('a, 'b, 'd)
    +    * }}}
    +    */
    +  def join(right: Table, joinPredicate: Expression): Table = {
    +    join(right, joinPredicate, JoinType.INNER)
    +  }
    +
    +  /**
    +    * Joins two [[Table]]s. Similar to an SQL left outer join. The fields 
of the two joined
    +    * operations must not overlap, use [[as]] to rename fields if 
necessary.
    +    *
    +    * Note: Both tables must be bound to the same [[TableEnvironment]] and 
its [[TableConfig]] must
    +    * have nullCheck enables.
    --- End diff --
    
    should be "... must have nullCheck enableD"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to