sjwiesman commented on a change in pull request #15858:
URL: https://github.com/apache/flink/pull/15858#discussion_r629482322
##########
File path:
flink-libraries/flink-state-processing-api/src/test/java/org/apache/flink/state/api/utils/SavepointTestBase.java
##########
@@ -33,15 +35,21 @@
import java.io.IOException;
import java.util.Arrays;
import java.util.Collection;
+import java.util.EnumSet;
+import java.util.Set;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.TimeUnit;
import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import static org.apache.flink.runtime.execution.ExecutionState.RUNNING;
/** A test base that includes utilities for taking a savepoint. */
public abstract class SavepointTestBase extends AbstractTestBase {
public <T extends WaitingFunction> String takeSavepoint(
- T waitingFunction, Function<T, StreamExecutionEnvironment>
jobGraphFactory) {
+ T waitingFunction /*todo: inline and delete class?*/,
Review comment:
If it can be safely inlined then +1. The more we can simplify the
better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
