Github user skavulya commented on the pull request:

    https://github.com/apache/flink/pull/656#issuecomment-218380988
  
    @tillrohrmann I updated the loss functions and regularization penalties 
based on your branch. I was not sure whether to update the gradient descent 
algorithm to pass the regularization penalty as a parameter in this branch so I 
kept the GradientDescent API as-is. 
    
    Let me know if you would like me to change the GradientDescent API to 
GradientDescent().setRegularizationPenalty(L1Regularization) and I will update 
my branch, squash the commits, and create a PR. 
https://github.com/apache/flink/compare/master...skavulya:loss-functions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to