[ 
https://issues.apache.org/jira/browse/FLINK-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329646#comment-17329646
 ] 

Flink Jira Bot commented on FLINK-14810:
----------------------------------------

This issue has been labeled "stale-minor" for 7 days. It is closed now. If you 
are still affected by this or would like to raise the priority of this ticket 
please re-open, removing the label "auto-closed" and raise the ticket priority 
accordingly.

> It's weird that copy julianDateFloor from DateTimeUtils and change the 
> implementation
> -------------------------------------------------------------------------------------
>
>                 Key: FLINK-14810
>                 URL: https://issues.apache.org/jira/browse/FLINK-14810
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / Planner
>            Reporter: Zhenghua Gao
>            Priority: Minor
>              Labels: stale-minor
>
> In SqlDateTimeUtils we copied *julianToLocalDate* from DateTimeUtils and 
> changed the implementation. It's weird to use an *entirely* *different* 
> implementation to do the same thing.
> One possible improvement of the new one is support TimeUnitRange.QUARTER. But 
> the logic to calculate year/month/day is totally different.
>   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to