Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1947#discussion_r61443006
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
    @@ -683,6 +688,9 @@ else if (STATE_UPDATER.compareAndSet(this, current, 
ExecutionState.FAILED)) {
     
                                // remove all of the tasks library resources
                                libraryCache.unregisterTask(jobId, executionId);
    +                           
    +                           //Uncomment before Merging!!!
    +                           //metrics.close();
    --- End diff --
    
    it makes it a bit easier to try out; without this the metrics are no longer 
exposed when the job is finished. so if you run one of the examples with the 
built-in data you'll see nothing (probably).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to