zentol commented on a change in pull request #15707:
URL: https://github.com/apache/flink/pull/15707#discussion_r618322039
##########
File path:
flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/junit/RetryRule.java
##########
@@ -25,19 +25,24 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import javax.annotation.Nullable;
+
/**
* A rule to retry failed tests for a fixed number of times.
*
- * <p>Add the {@link RetryRule} to your test and annotate tests with {@link
RetryOnFailure}.
+ * <p>Add the {@link RetryRule} to your test class and annotate the class
and/or tests with {@link
+ * RetryOnFailure} or {@link RetryOnException}. If both the class and test is
annotated, then only
+ * the latter annotation is taken into account.
*
* <pre>
+ * {@literal @}RetryOnFailure(times=1)
* public class YourTest {
*
* {@literal @}Rule
* public RetryRule retryRule = new RetryRule();
*
* {@literal @}Test
- * {@literal @}RetryOnFailure(times=1)
+ * {@literal @}RetryOnFailure(times=2)
Review comment:
eror rduring rebasing; similar to the annotatiosn the javadocs were
intended to have 1 test case without an annotation, and one that is distinct
from the class annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
