[ 
https://issues.apache.org/jira/browse/FLINK-22372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325759#comment-17325759
 ] 

Wong Mulan edited comment on FLINK-22372 at 4/20/21, 12:55 PM:
---------------------------------------------------------------

Please assign this issue to me, I want to fix it, thanks. cc [~twalthr]


was (Author: ana4):
Please assign this issue to me, I want to fix it,  thanks. 

> Rename LogicalTypeCasts class variables in the castTo method.
> -------------------------------------------------------------
>
>                 Key: FLINK-22372
>                 URL: https://issues.apache.org/jira/browse/FLINK-22372
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / API
>    Affects Versions: 1.12.3, 1.13.1
>            Reporter: Wong Mulan
>            Priority: Minor
>              Labels: pull-request-available
>
> castTo parameter has a mistake name. It should be 'targetType'.
> {code:java}
>     // Old
>     private static CastingRuleBuilder castTo(LogicalTypeRoot sourceType) {
>         return new CastingRuleBuilder(sourceType);
>     }
>     // New
>     private static CastingRuleBuilder castTo(LogicalTypeRoot targetType) {
>         return new CastingRuleBuilder(targetType);
>     }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to