[ 
https://issues.apache.org/jira/browse/FLINK-22372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wong Mulan updated FLINK-22372:
-------------------------------
    Description: 
castTo parameter has a mistake name. It should be 'targetType'.
{code:java}
    // Old
    private static CastingRuleBuilder castTo(LogicalTypeRoot sourceType) {
        return new CastingRuleBuilder(sourceType);
    }
    // New
    private static CastingRuleBuilder castTo(LogicalTypeRoot targetType) {
        return new CastingRuleBuilder(targetType);
    }
{code}

  was:
castTo parameter has a mistake name. It should be 'targetType'.
{code:java}
    // Old
    private static CastingRuleBuilder castTo(LogicalTypeRoot sourceType) {
        return new CastingRuleBuilder(sourceType);
    }
    // New
    private static CastingRuleBuilder castTo(LogicalTypeRoot targetType) {
        return new CastingRuleBuilder(targetType);
    }
{code}



> Rename LogicalTypeCasts class variables in the castTo method.
> -------------------------------------------------------------
>
>                 Key: FLINK-22372
>                 URL: https://issues.apache.org/jira/browse/FLINK-22372
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / API
>    Affects Versions: 1.12.3, 1.13.1
>            Reporter: Wong Mulan
>            Priority: Minor
>
> castTo parameter has a mistake name. It should be 'targetType'.
> {code:java}
>     // Old
>     private static CastingRuleBuilder castTo(LogicalTypeRoot sourceType) {
>         return new CastingRuleBuilder(sourceType);
>     }
>     // New
>     private static CastingRuleBuilder castTo(LogicalTypeRoot targetType) {
>         return new CastingRuleBuilder(targetType);
>     }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to