[ 
https://issues.apache.org/jira/browse/FLINK-22358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325171#comment-17325171
 ] 

Stephan Ewen commented on FLINK-22358:
--------------------------------------

My suggestion would be to do it the following way:
  - The iterator sources classes are all {{@PublicEvolving}}: They are simple 
and stable across the 1.13 release.
  - The top-level Split Reader API classes are {{@PublicEvolving}}: 
{{SourceReaderBase}}, {{SplitReader}}, {{RecordEmitter}}, ...
  - The remaining classes used by the {{SourceReaderBase}} are {{@Internal}}: 
{{FutureCompletingBlockingQueue}}, {{SplitFetcher}}, {{SplitFetcherManager}}.

A PR that illustrated those suggestions is: 
https://github.com/apache/flink/pull/15679

I think this is NOT blocking the 1.13 release, it can be cherry-picked into the 
{{release-1.13}} branch later.

> Add missing stability annotation to Split Reader API classes
> ------------------------------------------------------------
>
>                 Key: FLINK-22358
>                 URL: https://issues.apache.org/jira/browse/FLINK-22358
>             Project: Flink
>          Issue Type: Task
>          Components: Connectors / Common
>            Reporter: Stephan Ewen
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.14.0, 1.13.1
>
>
> The Split Reader API currently has no stability annotations, it is unclear 
> which classes are public API, which are internal, which are stable, and which 
> are evolving.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to