curcur commented on pull request #15636:
URL: https://github.com/apache/flink/pull/15636#issuecomment-822598829
Thanks, @rkhachatryan for the fix. I am mostly fine with this PR with
one-or-two places not completely understand. Let's sync up offline tomorrow.
Besides that, I think
1. the code needs some clean-up. There are a few classes for example
`JdbcXaFacadeTestHelper` having several methods unused.
2. the first and second commit does not self-compile because in
`JdbcXaSinkMigrationTest` and
`JdbcXaSinkTestBase`'s
`getDbMetadata().getUser()`,
`getDbMetadata().getPassword()`
methods not found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
