LadyForest commented on a change in pull request #13011:
URL: https://github.com/apache/flink/pull/13011#discussion_r615933282
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
##########
@@ -1072,6 +1086,75 @@ private TableResult buildShowResult(String columnName,
String[] objects) {
Arrays.stream(objects).map((c) -> new
String[]{c}).toArray(String[][]::new));
}
+ private TableResult buildShowCreateTableResult(CatalogBaseTable table,
ObjectIdentifier sqlIdentifier) {
Review comment:
> Personally, I don't like to add more and more methods in the
`TableEnvironmentImpl`, this makes the class fat and hard to maintain. I think
such methods can be utilities in a separate class, e.g. `ShowStatementUtils`
+1 and I think we can open another PR to improve this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
